SS-2016-010: ReadOnly transformation for formfields exploitable

Severity:

Low (?)

Identifier:

SS-2016-010

Versions Affected:

3.1.20 and below, 3.2.0 to 3.2.5, 3.3.0 to 3.3.3

Versions Fixed:

3.1.21, 3.2.6, 3.3.4, 3.4.2, 3.5.0

Release Date:

2016-11-29

Form fields returning isReadonly() as true are vulnerable to reflected XSS injections. This includes ReadonlyField, LookupField, HTMLReadonlyField, as well as special purpose fields like TimeField_Readonly. Values submitted to through these form fields are not filtered out from the form session data, and might be shown to the user depending on the form behaviour. For example, form validation errors cause the form to re-render with previously submitted values by default.

SilverStripe forms automatically load values from request data (GET and POST), which enables malicious use of URLs if your form uses these fields and doesn't overwrite data on form construction.

Readonly and disabled form fields are already filtered out in Form->saveInto(), so maliciously submitted data on these fields doesn't make it into the database unless you are accessing form values directly in your saving logic.

Discovered by employers of security-assessment.com, division of Dimension Data.